Report removal, hotfix for CRAN #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doesn't fit the scope of the package to warrant further support.
mghoff
reviewed
Apr 8, 2024
NEWS.md
Outdated
| # eia 0.4.2 | ||
|
|
||
| * Removed one-off, non-API, report download function that no longer works but also do not intend to support within the scope of the package. | ||
| * Removed related. no longer needed package imports. |
There was a problem hiding this comment.
Did you want a comma after the word "related"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing old one-off functionality. This was originally intended to be expanded into something much broader than a single report but never got any traction and does not fit the scope of the rest of the package. It's broken now, so a quick fix is needed for CRAN. But I also don't see a reason to support a one-off non-API function that downloads a single specific Excel file from the EIA website. That doesn't need its own wrapper function in the package. I have left the source code in-place but commented it out and anything related to it.
This also happens to reduce package imports.